From ec72ef1e68cdbd6938c713294dab97ecee25dc68 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Mon, 24 Mar 2025 17:22:48 +0200
Subject: fix termination of the event loop

---
 internal/eventloop.go | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

(limited to 'internal/eventloop.go')

diff --git a/internal/eventloop.go b/internal/eventloop.go
index ae3f887..0be7b7e 100644
--- a/internal/eventloop.go
+++ b/internal/eventloop.go
@@ -51,7 +51,7 @@ func newEventLoop(flags flags.Flags) *eventLoop {
 }
 
 func (e *eventLoop) stats() string {
-	fmt.Println("Waiting for staps to be ready")
+	fmt.Println("Waiting for stats to be ready")
 	<-e.done
 	duration := time.Since(e.startTime)
 
@@ -111,13 +111,11 @@ func (e *eventLoop) events(ctx context.Context, rawCh <-chan []byte) <-chan *eve
 					continue
 				}
 				e.processRawEvent(raw, ch)
+			case <-ctx.Done():
+				fmt.Println("Stopping event loop")
+				return
 			default:
-				select {
-				case <-ctx.Done():
-					return
-				default:
-					time.Sleep(time.Millisecond * 10)
-				}
+				time.Sleep(time.Millisecond * 10)
 			}
 		}
 	}()
-- 
cgit v1.2.3


From b1d77d2d891f04b710d610b47388e431fc519a07 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Mon, 24 Mar 2025 17:56:23 +0200
Subject: initial dup

---
 internal/eventloop.go | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

(limited to 'internal/eventloop.go')

diff --git a/internal/eventloop.go b/internal/eventloop.go
index 0be7b7e..7d13839 100644
--- a/internal/eventloop.go
+++ b/internal/eventloop.go
@@ -262,21 +262,26 @@ func (e *eventLoop) syscallExit(exitEv event.Event, ch chan<- *event.Pair) {
 			break
 		}
 
+		fdFile, ok := ev.File.(file.FdFile)
+		if !ok {
+			panic("expected a file.FdFile")
+		}
+
+		// See fcntl(2) for implementation details
 		switch v.Cmd {
 		case syscall.F_SETFL:
-			fdFile, ok := ev.File.(file.FdFile)
-			if !ok {
-				panic("expected a file.FdFile")
-			}
-			// fcntl(2)
 			canChange := syscall.O_APPEND | syscall.O_ASYNC | syscall.O_DIRECT | syscall.O_NOATIME | syscall.O_NONBLOCK
-			fdFile.Flags |= (int32(v.Arg) & int32(canChange))
+			*fdFile.Flags |= (int32(v.Arg) & int32(canChange))
 			ev.File = fdFile
 			e.files[fd] = fdFile
 		case syscall.F_DUPFD:
-			fmt.Println("TODO: F_DUPFD with fcntl not yet implememented")
+			// TODO: Re-read dup(2), maybe they don't share the same open flags?
+			newFd := int32(retEvent.Ret)
+			e.files[newFd] = fdFile.Dup(newFd)
 		case syscall.F_DUPFD_CLOEXEC:
-			fmt.Println("TODO: F_DUPFD_CLOEXEC with fcntl not yet implememented")
+			newFd := int32(retEvent.Ret)
+			e.files[newFd] = fdFile.Dup(newFd) // Also set O_CLOEXEC
+			fmt.Println("TODO: F_DUPFD_CLOEXEC with fcntl not yet fully implememented")
 		}
 
 	default:
-- 
cgit v1.2.3


From 375d092f4240587c7aae8dab40b2b488633c151c Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Mon, 24 Mar 2025 18:02:12 +0200
Subject: more on this

---
 internal/eventloop.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'internal/eventloop.go')

diff --git a/internal/eventloop.go b/internal/eventloop.go
index 7d13839..90eaa7e 100644
--- a/internal/eventloop.go
+++ b/internal/eventloop.go
@@ -275,13 +275,13 @@ func (e *eventLoop) syscallExit(exitEv event.Event, ch chan<- *event.Pair) {
 			ev.File = fdFile
 			e.files[fd] = fdFile
 		case syscall.F_DUPFD:
-			// TODO: Re-read dup(2), maybe they don't share the same open flags?
 			newFd := int32(retEvent.Ret)
 			e.files[newFd] = fdFile.Dup(newFd)
 		case syscall.F_DUPFD_CLOEXEC:
 			newFd := int32(retEvent.Ret)
-			e.files[newFd] = fdFile.Dup(newFd) // Also set O_CLOEXEC
-			fmt.Println("TODO: F_DUPFD_CLOEXEC with fcntl not yet fully implememented")
+			duppedFd := fdFile.Dup(newFd)
+			*duppedFd.Flags |= syscall.O_CLOEXEC
+			e.files[newFd] = duppedFd
 		}
 
 	default:
-- 
cgit v1.2.3


From a78769805d408308a1d85f9b2fb45a1af3450f13 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Mon, 24 Mar 2025 18:08:34 +0200
Subject: more debugging

---
 internal/eventloop.go | 1 +
 1 file changed, 1 insertion(+)

(limited to 'internal/eventloop.go')

diff --git a/internal/eventloop.go b/internal/eventloop.go
index 90eaa7e..f7bfa9a 100644
--- a/internal/eventloop.go
+++ b/internal/eventloop.go
@@ -270,6 +270,7 @@ func (e *eventLoop) syscallExit(exitEv event.Event, ch chan<- *event.Pair) {
 		// See fcntl(2) for implementation details
 		switch v.Cmd {
 		case syscall.F_SETFL:
+			fmt.Println("DEBUG", fdFile)
 			canChange := syscall.O_APPEND | syscall.O_ASYNC | syscall.O_DIRECT | syscall.O_NOATIME | syscall.O_NONBLOCK
 			*fdFile.Flags |= (int32(v.Arg) & int32(canChange))
 			ev.File = fdFile
-- 
cgit v1.2.3