From 7d6f3098976a9e3cfcd8d7f764486645a62188ba Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Thu, 10 Jul 2025 22:58:00 +0300 Subject: Update TODO.md and remove obsolete unit test comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove 5 obsolete "TODO: Unit test this" comments from eventloop.go for event types that already have comprehensive test coverage - Keep TODO comment for FcntlEvent which still needs tests - Reorganize TODO.md with prioritized task list based on all TODOs found across the codebase - Add priority levels: High (core functionality), Medium (additional syscalls), Low (less common features), and General improvements - Document completed tasks to acknowledge test coverage achievements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- internal/eventloop.go | 5 ----- 1 file changed, 5 deletions(-) (limited to 'internal/eventloop.go') diff --git a/internal/eventloop.go b/internal/eventloop.go index 679d69f..9a64647 100644 --- a/internal/eventloop.go +++ b/internal/eventloop.go @@ -219,13 +219,11 @@ func (e *eventLoop) tracepointExited(exitEv event.Event, ch chan<- *event.Pair) } e.comms[openEv.Tid] = comm - // TODO: Unit test this case *NameEvent: nameEvent := ep.EnterEv.(*NameEvent) ep.File = file.NewOldnameNewname(nameEvent.Oldname[:], nameEvent.Newname[:]) ep.Comm = e.comm(ep.EnterEv.GetTid()) - // TODO: Unit test this case *PathEvent: nameEvent := ep.EnterEv.(*PathEvent) if ep.Is(SYS_ENTER_CREAT) { @@ -240,7 +238,6 @@ func (e *eventLoop) tracepointExited(exitEv event.Event, ch chan<- *event.Pair) } ep.Comm = e.comm(ep.EnterEv.GetTid()) - // TODO: Unit test this case *FdEvent: fd := ep.EnterEv.(*FdEvent).Fd if file_, ok := e.files[fd]; ok { @@ -268,7 +265,6 @@ func (e *eventLoop) tracepointExited(exitEv event.Event, ch chan<- *event.Pair) } } - // TODO: Unit test this case *Dup3Event: dup3Event := ep.EnterEv.(*Dup3Event) fd := int32(dup3Event.Fd) @@ -294,7 +290,6 @@ func (e *eventLoop) tracepointExited(exitEv event.Event, ch chan<- *event.Pair) e.files[newFd] = duppedFdFile } - // TODO: Unit test this case *NullEvent: ep.Comm = e.comm(ep.EnterEv.GetTid()) if !e.filter.eventPair(ep) { -- cgit v1.2.3