From 4df620818f603564b2e6f4def6052baa72b2fbb1 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Fri, 29 May 2026 17:22:56 +0300 Subject: utime/utimes: classify as FS family (fix Misc misclassification) utime(2) and utimes(2) change a file's access/modification times by a real filesystem path (filename at args[0]). The path was already captured (KindPathname), but both syscalls fell through to FamilyMisc instead of joining their siblings utimensat/futimesat in FamilyFS. Add them to fsSyscalls and regenerate; the only generated change is trace IDs 1034-1037 flipping FamilyMisc -> FamilyFS. Lock-in coverage: - family_test.go asserts utime/utimes/utimensat/futimesat are all FamilyFS. - classify_test.go + FormatUtime fixture assert utime is KindPathname with PathnameField "filename" (path captured even though it is a char* string, unlike domain/host name args). - New ioworkload scenarios utime-basic/utimes/enoent and integration tests TestUtimeBasic/Utimes/Enoent verify the path is captured at runtime, including on the ENOENT error path. Docs updated: moved utime/utimes from Misc to FS in docs/syscall-tracing-plan.md to keep the drift tests green. Co-Authored-By: Claude Opus 4.8 --- internal/generate/testdata.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'internal/generate/testdata.go') diff --git a/internal/generate/testdata.go b/internal/generate/testdata.go index 9676491..50efc00 100644 --- a/internal/generate/testdata.go +++ b/internal/generate/testdata.go @@ -370,6 +370,25 @@ format: print fmt: "pathname: 0x%08lx", ((unsigned long)(REC->pathname)) ` +// FormatUtime mirrors the real sys_enter_utime tracepoint format: its first +// argument "filename" is a genuine const char * filesystem path (args[0]), +// so utime classifies as KindPathname with PathnameField "filename" — the +// path is captured, just like its siblings utimensat/futimesat. +const FormatUtime = `name: sys_enter_utime +ID: 1035 +format: + field:unsigned short common_type; offset:0; size:2; signed:0; + field:unsigned char common_flags; offset:2; size:1; signed:0; + field:unsigned char common_preempt_count; offset:3; size:1; signed:0; + field:int common_pid; offset:4; size:4; signed:1; + + field:int __syscall_nr; offset:8; size:4; signed:1; + field:char * filename; offset:16; size:8; signed:0; + field:struct utimbuf * times; offset:24; size:8; signed:0; + +print fmt: "filename: 0x%08lx, times: 0x%08lx", ((unsigned long)(REC->filename)), ((unsigned long)(REC->times)) +` + const FormatDup3 = `name: sys_enter_dup3 ID: 922 format: -- cgit v1.2.3