From f86699a94bdde7d973ba5d6fa3e7ca4ab2f234fb Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Fri, 8 May 2026 19:43:33 +0300 Subject: add duration metric, tolerate missing tracepoints, ship el8 build - Bubbles, treemap, icicle, and the live flamegraph 'b' cycle now include syscall duration (sum) as a third metric alongside events and bytes. Statsengine snapshots expose TotalLatencyNs to support this. - AttachAll takes an optional warn callback. Production passes one so older kernels that lack newer tracepoints log a warning and keep going instead of aborting startup. - Dockerfile.el8 + scripts/build-with-docker-el8.sh + mage buildDockerEl8 produce ior.el8, a static binary built against Rocky Linux 8 glibc for RHEL/Rocky/Alma 8 hosts. - README.md documents installing mage and the new el8 target. --- internal/ior_bpfsetup.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'internal/ior_bpfsetup.go') diff --git a/internal/ior_bpfsetup.go b/internal/ior_bpfsetup.go index 3500106..9ab9186 100644 --- a/internal/ior_bpfsetup.go +++ b/internal/ior_bpfsetup.go @@ -3,6 +3,7 @@ package internal import ( "context" "fmt" + "os" appconfig "ior/internal/config" "ior/internal/flags" @@ -65,7 +66,14 @@ func setupBPFModule(parentCtx context.Context, cfg flags.Config) (*bpf.Module, * } mgr := probemanager.NewManager(libbpfTracepointModule{module: bpfModule}) - if err := mgr.AttachAll(cfg.ShouldIAttachTracepoint, tracepoints.List); err != nil { + // Per-syscall attach failures are non-fatal: on older kernels the + // tracepoint may be absent (e.g. binary built against a newer kernel). + // We log and skip; the affected probe stays in the manager with its + // lastErr set, so States() and the TUI surface the failure. + warn := func(syscall string, err error) { + fmt.Fprintf(os.Stderr, "ior: skipping tracepoint for %s: %v\n", syscall, err) + } + if err := mgr.AttachAll(cfg.ShouldIAttachTracepoint, tracepoints.List, warn); err != nil { mgr.Close() bpfModule.Close() return nil, nil, releaseBindings, setupBPFModuleError("attach probes", err) -- cgit v1.2.3