From d2ebb8cf2c5f0fccdd703cc64b9f8cecfb539bf9 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Tue, 10 Mar 2026 07:52:33 +0200 Subject: tui/flamegraph: tighten arrow escape parsing (task 423) --- internal/tui/flamegraph/model_test.go | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'internal/tui/flamegraph/model_test.go') diff --git a/internal/tui/flamegraph/model_test.go b/internal/tui/flamegraph/model_test.go index 23c44e1..c2626cd 100644 --- a/internal/tui/flamegraph/model_test.go +++ b/internal/tui/flamegraph/model_test.go @@ -612,6 +612,25 @@ func TestArrowEscapeSequencesAreRecognized(t *testing.T) { } } +func TestArrowEscapeSequencesRejectMalformedValues(t *testing.T) { + tests := []struct { + name string + key string + ansiCode byte + }{ + {name: "missing escape", key: "up", ansiCode: 'A'}, + {name: "too short", key: "\x1b[", ansiCode: 'A'}, + {name: "wrong final", key: "\x1b[A", ansiCode: 'B'}, + {name: "unsupported introducer", key: "\x1bPA", ansiCode: 'A'}, + {name: "application mode with extra payload", key: "\x1bO1A", ansiCode: 'A'}, + } + for _, tc := range tests { + if isArrowEscapeSequence(tc.key, tc.ansiCode) { + t.Fatalf("expected %s sequence %q to be rejected", tc.name, tc.key) + } + } +} + func TestFilteredNavigationSkipsHiddenBranches(t *testing.T) { m := NewModel(nil) m.frames = []tuiFrame{ -- cgit v1.2.3