From 83d68e56213c5107a4e24aceff61439c4e6644f4 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Wed, 13 May 2026 09:52:04 +0300 Subject: Revert "fix: surface rb.Poll errors instead of silently dropping them" This reverts commit 66956756ba018ed32a455aa57f04517af2c7357f. --- internal/ior_bpfsetup.go | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) (limited to 'internal') diff --git a/internal/ior_bpfsetup.go b/internal/ior_bpfsetup.go index 7575700..885d321 100644 --- a/internal/ior_bpfsetup.go +++ b/internal/ior_bpfsetup.go @@ -88,23 +88,13 @@ func setupBPFModule(parentCtx context.Context, cfg flags.Config) (*bpf.Module, * } // setupEventChannel initialises the BPF ring-buffer and returns the event channel. -// It starts polling the ring buffer and logs any fatal poll error to stderr so -// that a background ring-buffer failure does not go completely unnoticed. func setupEventChannel(bpfModule *bpf.Module) (chan []byte, error) { ch := make(chan []byte, appconfig.DefaultChannelBufferSize) rb, err := bpfModule.InitRingBuf("event_map", ch) if err != nil { return nil, err } - // Poll returns a channel that receives any fatal error from the background - // polling goroutine. Monitor it in a goroutine so the error is logged and - // does not silently drop events. - pollErrCh := rb.Poll(300) - go func() { - if err := <-pollErrCh; err != nil { - fmt.Fprintf(os.Stderr, "ior: ring buffer poll failed: %v\n", err) - } - }() + rb.Poll(300) return ch, nil } -- cgit v1.2.3