summaryrefslogtreecommitdiff
path: root/internal/service
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-04-30 10:42:32 +0300
committerPaul Buetow <paul@buetow.org>2026-04-30 10:42:32 +0300
commit0d7063e5c91efeb219a4be5b93525b0837c8d3be (patch)
treeaba069224950e8e0d00fadd82dc4b00e4a7c4117 /internal/service
parente971128cdc64aa81bba134faa65dc53bc2680d60 (diff)
fix(ca): translate sql.ErrNoRows to nil,nil for optional lookups
Repository methods that perform single-row queries now return (nil,nil) instead of leaking sql.ErrNoRows when a row is missing. This aligns with service-layer expectations (e.g. GetMediaDetail, ValidateSession, UpdateProgress, AssignTag, access checks) so normal missing data does not break app flows. Files changed: - internal/repository/media.go, user.go, set.go, set_permission.go, tag.go, note.go, playback_progress.go, playback_accumulator.go, session.go, share.go - internal/repository/sqlite_test.go (updated assertions) - internal/repository/sqlite_no_rows_test.go (new focused repository tests) - internal/service/no_rows_test.go (new focused service tests)
Diffstat (limited to 'internal/service')
-rw-r--r--internal/service/no_rows_test.go160
1 files changed, 160 insertions, 0 deletions
diff --git a/internal/service/no_rows_test.go b/internal/service/no_rows_test.go
new file mode 100644
index 0000000..0369db5
--- /dev/null
+++ b/internal/service/no_rows_test.go
@@ -0,0 +1,160 @@
+package service
+
+import (
+ "context"
+ "errors"
+ "testing"
+
+ "github.com/paul/kiss-media-player/internal/model"
+ "github.com/paul/kiss-media-player/internal/repository"
+)
+
+func TestService_NoRows_ReturnsNil(t *testing.T) {
+ ctx := context.Background()
+
+ t.Run("GetMediaDetail nil media", func(t *testing.T) {
+ store := &repository.MockStore{
+ MediaRepo: repository.MockMediaRepo{
+ GetMediaByIDFunc: func(ctx context.Context, id int64) (*model.Media, error) {
+ return nil, nil
+ },
+ },
+ }
+ svc := NewMediaService(store, newMockClock(), "/tmp/media")
+ detail, err := svc.GetMediaDetail(ctx, 99, 1)
+ if err != nil {
+ t.Fatalf("expected no error, got %v", err)
+ }
+ if detail != nil {
+ t.Fatalf("expected nil detail, got %+v", detail)
+ }
+ })
+
+ t.Run("GetNote nil", func(t *testing.T) {
+ store := &repository.MockStore{
+ NoteRepo: repository.MockNoteRepo{
+ GetNoteFunc: func(ctx context.Context, mediaID, userID int64) (*model.Note, error) {
+ return nil, nil
+ },
+ },
+ }
+ svc := NewMediaService(store, newMockClock(), "/tmp/media")
+ note, err := svc.GetNote(ctx, 1, 1)
+ if err != nil {
+ t.Fatalf("expected no error, got %v", err)
+ }
+ if note != nil {
+ t.Fatalf("expected nil note, got %+v", note)
+ }
+ })
+
+ t.Run("AssignTag creates missing tag", func(t *testing.T) {
+ store := &repository.MockStore{
+ TagRepo: repository.MockTagRepo{
+ GetTagByNameFunc: func(ctx context.Context, name string) (*model.Tag, error) {
+ return nil, nil
+ },
+ CreateTagFunc: func(ctx context.Context, name string) (int64, error) {
+ return 42, nil
+ },
+ AssignTagFunc: func(ctx context.Context, mediaID, tagID int64) error {
+ return nil
+ },
+ },
+ }
+ svc := NewMediaService(store, newMockClock(), "/tmp/media")
+ if err := svc.AssignTag(ctx, 1, 1, "newtag"); err != nil {
+ t.Fatalf("expected no error, got %v", err)
+ }
+ })
+
+ t.Run("UpdateProgress with nil accumulator", func(t *testing.T) {
+ store := &repository.MockStore{
+ PlaybackProgressRepo: repository.MockPlaybackProgressRepo{
+ UpsertProgressFunc: func(ctx context.Context, progress *model.PlaybackProgress) error {
+ return nil
+ },
+ },
+ PlaybackAccumulatorRepo: repository.MockPlaybackAccumulatorRepo{
+ GetAccumulatorFunc: func(ctx context.Context, sessionID string, mediaID int64) (*model.PlaybackAccumulator, error) {
+ return nil, nil
+ },
+ UpsertAccumulatorFunc: func(ctx context.Context, acc *model.PlaybackAccumulator) error {
+ return nil
+ },
+ },
+ MediaRepo: repository.MockMediaRepo{
+ IncrementPlayCountFunc: func(ctx context.Context, id int64) error {
+ return nil
+ },
+ },
+ }
+ svc := NewProgressService(store, newMockClock())
+ if err := svc.UpdateProgress(ctx, "sess", 1, 10, 5); err != nil {
+ t.Fatalf("expected no error, got %v", err)
+ }
+ })
+
+ t.Run("ValidateShareToken nil", func(t *testing.T) {
+ store := &repository.MockStore{
+ ShareRepo: repository.MockShareRepo{
+ GetShareByTokenFunc: func(ctx context.Context, token string) (*model.Share, error) {
+ return nil, nil
+ },
+ },
+ }
+ svc := NewMediaService(store, newMockClock(), "/tmp/media")
+ sh, err := svc.ValidateShareToken(ctx, "nope")
+ if err != nil {
+ t.Fatalf("expected no error, got %v", err)
+ }
+ if sh != nil {
+ t.Fatalf("expected nil share, got %+v", sh)
+ }
+ })
+
+ t.Run("StreamSharedMedia missing share", func(t *testing.T) {
+ store := &repository.MockStore{
+ ShareRepo: repository.MockShareRepo{
+ GetShareByTokenFunc: func(ctx context.Context, token string) (*model.Share, error) {
+ return nil, nil
+ },
+ },
+ }
+ svc := NewMediaService(store, newMockClock(), "/tmp/media")
+ _, err := svc.StreamSharedMedia(ctx, "nope")
+ if err == nil {
+ t.Fatal("expected error for missing share")
+ }
+ })
+
+ t.Run("verifyAccess missing permission", func(t *testing.T) {
+ store := &repository.MockStore{
+ MediaRepo: repository.MockMediaRepo{
+ GetMediaByIDFunc: func(ctx context.Context, id int64) (*model.Media, error) {
+ return &model.Media{ID: 1, SetID: 1}, nil
+ },
+ },
+ UserRepo: repository.MockUserRepo{
+ GetUserByIDFunc: func(ctx context.Context, id int64) (*model.User, error) {
+ return &model.User{ID: 1, IsAdmin: false}, nil
+ },
+ },
+ SetRepo: repository.MockSetRepo{
+ GetSetByIDFunc: func(ctx context.Context, id int64) (*model.Set, error) {
+ return &model.Set{ID: 1}, nil
+ },
+ },
+ SetPermissionRepo: repository.MockSetPermissionRepo{
+ GetPermissionFunc: func(ctx context.Context, setID, userID int64) (*model.SetPermission, error) {
+ return nil, nil
+ },
+ },
+ }
+ svc := NewMediaService(store, newMockClock(), "/tmp/media")
+ _, err := svc.StreamMedia(ctx, 1, 1)
+ if !errors.Is(err, ErrForbidden) {
+ t.Fatalf("expected ErrForbidden, got %v", err)
+ }
+ })
+}