summaryrefslogtreecommitdiff
path: root/player-android/android/app
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-05-22 16:30:53 +0300
committerPaul Buetow <paul@buetow.org>2026-05-22 16:30:53 +0300
commit34e0053b156396d5c7be0831cabb71c041deadb9 (patch)
treefb83c03fe6f33c91f068f9086f0054df1422986e /player-android/android/app
parentb4a200fa07a5c659661a2a695c6cfe57c70e3ab1 (diff)
Fix review issues in AdminUsersScreen and related files (task db)
- Replace identity-equality optimistic-create revert with index-based logic (placeholderIdx) to avoid relying on reference equality - Replace insert(index) delete revert with append to avoid stale-index position jitter from concurrent mutations - Remove _RoleBadge key collision; update test to use text finders - currentUserProvider catch block returns null instead of User(id:0) to avoid colliding with the optimistic placeholder sentinel; fix broken comment - adminUserErrorMessage 400-branch delegates to dioErrorMessage to eliminate duplicated JSON body-parsing logic - Add Completer-backed optimistic placeholder visibility test - _EmptyView: replace magic height SizedBox with LayoutBuilder+Center - _CreateUserDialogState: inline _buildForm and _buildActions into build() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to 'player-android/android/app')
0 files changed, 0 insertions, 0 deletions