diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-19 19:15:14 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-19 19:15:14 +0300 |
| commit | 35aa611038c97a2ce27510e3898318afca37cac0 (patch) | |
| tree | edcfe117abc51d5ba33481d6b9b8c53d2b494dc2 /player-server/internal/api/handlers_test.go | |
| parent | 92edb836d45ccb9e096a4c9a8c2cabcebf133d19 (diff) | |
Complete s9 + aa: NewServerWithLogger returns error; share-page renderer extracted
Two related refactors that converged on internal/api/server.go.
s9 — NewServerWithLogger no longer panics on nil deps.Config. Returns
(*Server, error) so cmd/player/main.go can log a clear message and exit
cleanly when wiring is misconfigured. All callers updated, including
api unit tests that construct a Server directly.
aa — Share-page HTML rendering moved out of handlers_share.go into a
new internal/web package. internal/web/sharepage.go owns
SharePageRenderer and the private injectShareMedia helper; the api
handler now calls s.shareRenderer.Render(...) and routes errors via
http.Error. injectShareMedia coverage was moved alongside it in
internal/web/sharepage_test.go; the duplicate tests in
handlers_more_test.go were removed (placeholder comment left so the
reference is greppable). Server gained one new field (shareRenderer
*web.SharePageRenderer) and one new constructor line; production
wiring uses deps.StaticFS.
Background: both tasks were initially worked by separate sub-agents
that stopped mid-edit when usage limits hit; their WIP was preserved
in a stash and finalized in this commit. Tests rerun from a clean
state: full Go unit suite green, 25/25 LLM e2e, 22/22 Playwright.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Diffstat (limited to 'player-server/internal/api/handlers_test.go')
| -rw-r--r-- | player-server/internal/api/handlers_test.go | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/player-server/internal/api/handlers_test.go b/player-server/internal/api/handlers_test.go index fea6861..2c662b3 100644 --- a/player-server/internal/api/handlers_test.go +++ b/player-server/internal/api/handlers_test.go @@ -65,7 +65,10 @@ func newTestServer(t *testing.T, store repository.Store, hasher auth.Hasher, sm if len(streamer) > 0 { mediaStreamer = streamer[0] } - return NewServer(ServerDeps{ + // NewServer now returns an error when required deps (e.g. Config) are + // missing. Tests always pass a non-nil Config, so a failure here indicates + // a programming mistake in the test setup itself. + srv, err := NewServer(ServerDeps{ Store: store, Hasher: hasher, SessionManager: sm, @@ -84,6 +87,10 @@ func newTestServer(t *testing.T, store repository.Store, hasher auth.Hasher, sm StaticFS: fs, MediaStreamer: mediaStreamer, }) + if err != nil { + t.Fatalf("NewServer: %v", err) + } + return srv } func addSessionCookie(t *testing.T, store repository.Store, sm auth.SessionManager, userID int64) *http.Cookie { |