summaryrefslogtreecommitdiff
path: root/src/lib/album-photo-select.source.sh
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-06-28 09:08:22 +0300
committerPaul Buetow <paul@buetow.org>2026-06-28 09:08:22 +0300
commit94479238557adcab33a95fefbf752a3742b8a8ba (patch)
tree8a97bb2d616c58409617c4b5a3b5ed928246e827 /src/lib/album-photo-select.source.sh
parentfef68fe90d7f00d7d831c335b03119f11c2c927b (diff)
nr0: dry-run reuses real paging/redirect logic via shared helpers
collect_dry_run_page_plan re-derived page_count via the ceil formula and redirect_count via a magic "*4+2", duplicating logic owned by album_page_records (pagination) and render_page_view_redirects (redirect files). The preview could silently drift from a real --generate. Single source of truth: - album_page_count_for_image_count (album-photo-select.source.sh) owns the MAXPREVIEWS-per-page grouping count that album_page_records realises. - ALBUM_REDIRECTS_PER_PAGE=4 / ALBUM_REDIRECTS_LAST_PAGE_EXTRA=2 + album_redirect_count_for_page_count (album-render.source.sh) own the per-page (4) plus last-page-extra (2) redirect tally that render_page_view_redirects actually emits. dry-run now predicts both counts through these helpers (no dist files touched, side-effect free). Confirmed the real redirect count is page_count*4+2, so output is byte-identical: partial-final-page (3 preview pages / 14 navigation redirects) and empty album (0 / 0) unchanged. Regenerated bin/shuriken; just test/shellcheck/check-generated all pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'src/lib/album-photo-select.source.sh')
-rw-r--r--src/lib/album-photo-select.source.sh22
1 files changed, 21 insertions, 1 deletions
diff --git a/src/lib/album-photo-select.source.sh b/src/lib/album-photo-select.source.sh
index 2cb2e88..06190f7 100644
--- a/src/lib/album-photo-select.source.sh
+++ b/src/lib/album-photo-select.source.sh
@@ -20,12 +20,32 @@ album_photo_files() {
| maybe_shuffle
}
+# Pagination single source of truth (task nr0): how many preview pages a given
+# number of album photos splits into, with at most MAXPREVIEWS photos per page.
+# album_page_records below realises exactly this many records by grouping the
+# actual (shuffled) photo list, and the dry-run plan calls this helper to predict
+# the page count from the incoming-image tally WITHOUT enumerating dist files. So
+# the preview and a real --generate can never disagree on the page count: both
+# express "ceil(image_count / MAXPREVIEWS)" through this one definition. An empty
+# album yields 0 pages.
+album_page_count_for_image_count() {
+ local -ri image_count="$1"; shift
+
+ if (( image_count <= 0 )); then
+ printf '0\n'
+ return
+ fi
+ printf '%d\n' "$(( (image_count + MAXPREVIEWS - 1) / MAXPREVIEWS ))"
+}
+
# Group the album's photos into pages of at most MAXPREVIEWS, in their final
# (shuffled/sorted) order. The result is emitted one line per page as a
# tab-separated record "<page_num>\t<photo>\t<photo>..." so the caller can walk
# pages without keeping every page in memory at once. Order is fully
# deterministic (album_photo_files already applies the seeded shuffle), so the
-# downstream parallelism only changes timing, never which photo lands where.
+# downstream parallelism only changes timing, never which photo lands where. The
+# number of records produced here equals album_page_count_for_image_count of the
+# photo count (same MAXPREVIEWS-per-page grouping); see that helper.
album_page_records() {
local -r photos_dir="$1"; shift
local photo