summaryrefslogtreecommitdiff
path: root/internal/task
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-06-25 11:10:52 +0300
committerPaul Buetow <paul@buetow.org>2026-06-25 11:10:52 +0300
commit541fe26ddb20e00112d0bcbda9249625dfe5d245 (patch)
tree5f81675f24bfbb0dc9256cfdf8ce70b319c7fd35 /internal/task
parentf3b64f706e2df8ceffafdef916a127e8e22c296b (diff)
Fix gofmt and errcheck guardrails for task 2r0
Diffstat (limited to 'internal/task')
-rw-r--r--internal/task/operations_test.go10
-rw-r--r--internal/task/task_test.go34
2 files changed, 23 insertions, 21 deletions
diff --git a/internal/task/operations_test.go b/internal/task/operations_test.go
index 7abd4bd..bd2fc44 100644
--- a/internal/task/operations_test.go
+++ b/internal/task/operations_test.go
@@ -38,7 +38,7 @@ func TestModifyTask(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
err := modifyTask(tt.id, tt.args...)
-
+
// We can't test actual taskwarrior commands without it installed
// So we just test the validation
if tt.wantErr {
@@ -85,7 +85,7 @@ func TestSimpleTaskCommand(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
err := simpleTaskCommand(tt.id, tt.command)
-
+
// We can't test actual taskwarrior commands without it installed
// So we just test the validation
if tt.wantErr {
@@ -102,7 +102,7 @@ func TestSimpleTaskCommand(t *testing.T) {
func TestTaskOperationsValidation(t *testing.T) {
// Test that all task operations validate IDs
invalidID := -1
-
+
operations := []struct {
name string
fn func() error
@@ -119,7 +119,7 @@ func TestTaskOperationsValidation(t *testing.T) {
{"Annotate", func() error { return Annotate(invalidID, "note") }},
{"Denotate", func() error { return Denotate(invalidID, "note") }},
}
-
+
for _, op := range operations {
t.Run(op.name, func(t *testing.T) {
err := op.fn()
@@ -130,4 +130,4 @@ func TestTaskOperationsValidation(t *testing.T) {
}
})
}
-} \ No newline at end of file
+}
diff --git a/internal/task/task_test.go b/internal/task/task_test.go
index 556351f..f4567ba 100644
--- a/internal/task/task_test.go
+++ b/internal/task/task_test.go
@@ -17,7 +17,7 @@ import (
// target directory does not exist.
func TestSetDebugLog(t *testing.T) {
// Ensure the package-level state is clean before and after.
- t.Cleanup(func() { SetDebugLog("") }) //nolint:errcheck
+ t.Cleanup(func() { _ = SetDebugLog("") })
// Negative: directory does not exist — must return an error.
if err := SetDebugLog("/nonexistent-dir-xyz/debug.log"); err == nil {
@@ -40,7 +40,9 @@ func TestSetDebugLog(t *testing.T) {
// The run helper uses dbg.writer — verify that a write actually reaches
// the log file. We fake a task invocation by writing directly.
- fmt.Fprintln(dbg.writer, "test-entry")
+ if _, err := fmt.Fprintln(dbg.writer, "test-entry"); err != nil {
+ t.Fatalf("write debug log: %v", err)
+ }
content, err := os.ReadFile(logPath)
if err != nil {
t.Fatalf("read log file: %v", err)
@@ -79,8 +81,8 @@ func TestAddAndExport(t *testing.T) {
t.Fatal(err)
}
t.Cleanup(func() {
- os.Unsetenv("TASKDATA")
- os.Unsetenv("TASKRC")
+ _ = os.Unsetenv("TASKDATA")
+ _ = os.Unsetenv("TASKRC")
})
if err := Add("hello world", []string{"tag", "anothertag", "tasksamuraitesting"}); err != nil {
@@ -134,8 +136,8 @@ func TestRunLineSplitsCapturesAndStripsTaskPrefix(t *testing.T) {
}
origPath := os.Getenv("PATH")
- os.Setenv("PATH", tmp+":"+origPath)
- t.Cleanup(func() { os.Setenv("PATH", origPath) })
+ _ = os.Setenv("PATH", tmp+":"+origPath)
+ t.Cleanup(func() { _ = os.Setenv("PATH", origPath) })
result, err := RunLine(context.Background(), `task add "hello world" project:home`)
if err != nil {
@@ -171,8 +173,8 @@ func TestRunShellLineDisablesRecurrencePrompt(t *testing.T) {
}
origPath := os.Getenv("PATH")
- os.Setenv("PATH", tmp+":"+origPath)
- t.Cleanup(func() { os.Setenv("PATH", origPath) })
+ _ = os.Setenv("PATH", tmp+":"+origPath)
+ t.Cleanup(func() { _ = os.Setenv("PATH", origPath) })
if _, err := RunShellLine(context.Background(), `task 260 modify project:foo`); err != nil {
t.Fatalf("RunShellLine: %v", err)
@@ -200,8 +202,8 @@ func TestRunLineReturnsCapturedErrorOutput(t *testing.T) {
}
origPath := os.Getenv("PATH")
- os.Setenv("PATH", tmp+":"+origPath)
- t.Cleanup(func() { os.Setenv("PATH", origPath) })
+ _ = os.Setenv("PATH", tmp+":"+origPath)
+ t.Cleanup(func() { _ = os.Setenv("PATH", origPath) })
result, err := RunLine(context.Background(), "bad command")
if err == nil {
@@ -737,8 +739,8 @@ func TestLoadCompletionSources(t *testing.T) {
}
origPath := os.Getenv("PATH")
- os.Setenv("PATH", tmp+":"+origPath)
- t.Cleanup(func() { os.Setenv("PATH", origPath) })
+ _ = os.Setenv("PATH", tmp+":"+origPath)
+ t.Cleanup(func() { _ = os.Setenv("PATH", origPath) })
sources := LoadCompletionSources(context.Background())
if strings.Join(sources.Commands, ",") != "add,modify" {
@@ -782,8 +784,8 @@ func TestRecurringSeries(t *testing.T) {
}
origPath := os.Getenv("PATH")
- os.Setenv("PATH", tmp+":"+origPath)
- t.Cleanup(func() { os.Setenv("PATH", origPath) })
+ _ = os.Setenv("PATH", tmp+":"+origPath)
+ t.Cleanup(func() { _ = os.Setenv("PATH", origPath) })
tasks, err := RecurringSeries(context.Background(), "parent-uuid")
if err != nil {
@@ -820,8 +822,8 @@ func TestModifyHelpers(t *testing.T) {
t.Fatal(err)
}
t.Cleanup(func() {
- os.Unsetenv("TASKDATA")
- os.Unsetenv("TASKRC")
+ _ = os.Unsetenv("TASKDATA")
+ _ = os.Unsetenv("TASKRC")
})
if err := Add("hello", nil); err != nil {