From f75924987a1685055d4eb4517a0f2443c6f7d6be Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Tue, 23 Jun 2026 06:40:44 +0300 Subject: Reject typed nil Taskwarrior injection for vq0 --- internal/ui/table_test.go | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) (limited to 'internal/ui/table_test.go') diff --git a/internal/ui/table_test.go b/internal/ui/table_test.go index a9348ba..14e78ca 100644 --- a/internal/ui/table_test.go +++ b/internal/ui/table_test.go @@ -188,12 +188,24 @@ func TestNewWithTaskwarriorUsesFakeForAddTask(t *testing.T) { } func TestNewWithTaskwarriorRejectsNilClient(t *testing.T) { - _, err := NewWithTaskwarrior(nil, "firefox", nil) - if err == nil { - t.Fatalf("NewWithTaskwarrior with nil client succeeded") + tests := []struct { + name string + tw task.Taskwarrior + }{ + {name: "plain nil", tw: nil}, + {name: "typed nil", tw: (*fakeTaskwarrior)(nil)}, } - if got, want := err.Error(), "taskwarrior client is nil"; got != want { - t.Fatalf("NewWithTaskwarrior error = %q, want %q", got, want) + + for _, tc := range tests { + t.Run(tc.name, func(t *testing.T) { + _, err := NewWithTaskwarrior(nil, "firefox", tc.tw) + if err == nil { + t.Fatalf("NewWithTaskwarrior with nil client succeeded") + } + if got, want := err.Error(), "taskwarrior client is nil"; got != want { + t.Fatalf("NewWithTaskwarrior error = %q, want %q", got, want) + } + }) } } -- cgit v1.2.3