chore: fix code-quality and 100-go-mistakes findings

Addresses Taskwarrior findings for golangci-lint v2 config, deprecated APIs, unchecked test errors, dead code, and staticcheck cleanups.

Task UUIDs: 461c529c-5de3-4ceb-a761-5534f9f4342e, 8696d39e-d911-4ffe-8708-af1652a084b7, 0f63064b-be12-4fd6-a412-2904f94eb3dd, c051e84f-0e7b-48bc-8f16-e65133636ceb, 076cf172-e5fb-4f55-a1d6-1bce71e2f131, 1ed5b895-da61-4114-8321-cb129b24d6e1, 659311db-10af-4ec5-a08a-92240fa23489

1 files changed, 23 insertions, 7 deletions

diff --git a/internal/timer/operations_test.go b/internal/timer/operations_test.go
index c0480d7..68764c4 100644
--- a/internal/timer/operations_test.go
+++ b/internal/timer/operations_test.go
@@ -241,11 +241,16 @@ func TestTrackTime(t *testing.T) {
 		tracker := &mockTracker{}
 
 		// Start timer and let it run for a bit
-		state, _ := LoadState()
+		state, err := LoadState()
+		if err != nil {
+			t.Fatalf("LoadState() error = %v", err)
+		}
 		state.Running = true
 		state.StartTime = time.Now().Add(-5 * time.Minute)
 		state.ElapsedTime = 0
-		state.Save()
+		if err := state.Save(); err != nil {
+			t.Fatalf("state.Save() error = %v", err)
+		}
 
 		msg, err := TrackTimeWithTracker("test description", tracker)
 		if err != nil {
@@ -261,7 +266,10 @@ func TestTrackTime(t *testing.T) {
 			t.Fatalf("tracker minutes = %d, want around 5", tracker.minutes)
 		}
 
-		state, _ = LoadState()
+		state, err = LoadState()
+		if err != nil {
+			t.Fatalf("LoadState() error = %v", err)
+		}
 		if state.Running || state.ElapsedTime != 0 {
 			t.Fatalf("state after tracking = %+v, want reset stopped state", state)
 		}
@@ -272,17 +280,25 @@ func TestTrackTime(t *testing.T) {
 		tracker := &mockTracker{err: errTestTracker}
 
 		// Set up a stopped timer with some elapsed time
-		state, _ := LoadState()
+		state, err := LoadState()
+		if err != nil {
+			t.Fatalf("LoadState() error = %v", err)
+		}
 		state.Running = false
 		state.ElapsedTime = 10 * time.Minute
-		state.Save()
+		if err := state.Save(); err != nil {
+			t.Fatalf("state.Save() error = %v", err)
+		}
 
-		_, err := TrackTimeWithTracker("another test", tracker)
+		_, err = TrackTimeWithTracker("another test", tracker)
 		if err == nil {
 			t.Fatal("TrackTimeWithTracker() error = nil, want tracker error")
 		}
 
-		state, _ = LoadState()
+		state, err = LoadState()
+		if err != nil {
+			t.Fatalf("LoadState() error = %v", err)
+		}
 		if state.Running {
 			t.Fatal("state.Running = true, want false after failed tracking")
 		}