summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-04-08 10:16:32 +0300
committerPaul Buetow <paul@buetow.org>2026-04-08 10:16:32 +0300
commitf21b8688c9e8397f3e7720a9bde773f4f1128e71 (patch)
treeb51f0b6b03231eaa133834125528371307406ffd
parentfc1857e1b485e7011fb80b40ee7e5146fe2350e7 (diff)
audio: propagate Close error from OpenAI TTS output file
Use named return and defer like anki/generator GenerateCSV so a failed out.Close() is returned when io.Copy already succeeded. Made-with: Cursor
-rw-r--r--internal/audio/openai_provider.go6
1 files changed, 4 insertions, 2 deletions
diff --git a/internal/audio/openai_provider.go b/internal/audio/openai_provider.go
index 58a9fb6..ec19246 100644
--- a/internal/audio/openai_provider.go
+++ b/internal/audio/openai_provider.go
@@ -41,7 +41,7 @@ func NewOpenAIProvider(config OpenAIAudioConfig, outputFormat string) (Provider,
}
// GenerateAudio generates audio using OpenAI TTS
-func (p *OpenAIProvider) GenerateAudio(ctx context.Context, text string, outputFile string) error {
+func (p *OpenAIProvider) GenerateAudio(ctx context.Context, text string, outputFile string) (err error) {
ctx, cancel := httpctx.WithTimeoutUnlessSet(ctx, httpctx.OpenAIHTTPTimeout)
defer cancel()
@@ -123,7 +123,9 @@ func (p *OpenAIProvider) GenerateAudio(ctx context.Context, text string, outputF
return fmt.Errorf("failed to create output file: %w", err)
}
defer func() {
- _ = out.Close()
+ if closeErr := out.Close(); err == nil && closeErr != nil {
+ err = fmt.Errorf("failed to close output file: %w", closeErr)
+ }
}()
// Copy the audio data