From aa733f9a86b02d7b4d6edd8022a44e4ba417b24c Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Sun, 8 Mar 2026 08:41:59 +0200
Subject: test(task-374): fix errcheck issues in tests and support code

---
 internal/cli/command_test.go | 40 +++++++++++++++++++++++++++++++---------
 1 file changed, 31 insertions(+), 9 deletions(-)

(limited to 'internal/cli/command_test.go')

diff --git a/internal/cli/command_test.go b/internal/cli/command_test.go
index aac2e60..c6fa3d8 100644
--- a/internal/cli/command_test.go
+++ b/internal/cli/command_test.go
@@ -151,8 +151,14 @@ output:
 			InitConfig(tt.cfgFile)
 
 			// Test environment variable prefix
-			os.Setenv("TOTALRECALL_TEST_VAR", "test-value")
-			defer os.Unsetenv("TOTALRECALL_TEST_VAR")
+			if err := os.Setenv("TOTALRECALL_TEST_VAR", "test-value"); err != nil {
+				t.Fatalf("Failed to set env var: %v", err)
+			}
+			defer func() {
+				if err := os.Unsetenv("TOTALRECALL_TEST_VAR"); err != nil {
+					t.Errorf("Failed to unset env var: %v", err)
+				}
+			}()
 
 			if viper.GetString("test_var") != "test-value" {
 				t.Error("Environment variable not properly loaded")
@@ -204,10 +210,18 @@ func TestGetOpenAIKey(t *testing.T) {
 
 			// Set up environment
 			if tt.envKey != "" {
-				os.Setenv("OPENAI_API_KEY", tt.envKey)
-				defer os.Unsetenv("OPENAI_API_KEY")
+				if err := os.Setenv("OPENAI_API_KEY", tt.envKey); err != nil {
+					t.Fatalf("Failed to set OPENAI_API_KEY: %v", err)
+				}
+				defer func() {
+					if err := os.Unsetenv("OPENAI_API_KEY"); err != nil {
+						t.Errorf("Failed to unset OPENAI_API_KEY: %v", err)
+					}
+				}()
 			} else {
-				os.Unsetenv("OPENAI_API_KEY")
+				if err := os.Unsetenv("OPENAI_API_KEY"); err != nil {
+					t.Fatalf("Failed to unset OPENAI_API_KEY: %v", err)
+				}
 			}
 
 			// Set up config
@@ -239,11 +253,19 @@ func TestBindFlagsToViper(t *testing.T) {
 	setupFlags(cmd, flags)
 
 	// Set some flag values
-	cmd.Flags().Set("output", "/test/output")
-	cmd.Flags().Set("format", "wav")
-	cmd.Flags().Set("openai-model", "tts-1-hd")
+	if err := cmd.Flags().Set("output", "/test/output"); err != nil {
+		t.Fatalf("Failed to set output flag: %v", err)
+	}
+	if err := cmd.Flags().Set("format", "wav"); err != nil {
+		t.Fatalf("Failed to set format flag: %v", err)
+	}
+	if err := cmd.Flags().Set("openai-model", "tts-1-hd"); err != nil {
+		t.Fatalf("Failed to set openai-model flag: %v", err)
+	}
 
-	bindFlagsToViper(cmd)
+	if err := bindFlagsToViper(cmd); err != nil {
+		t.Fatalf("bindFlagsToViper() failed: %v", err)
+	}
 
 	// Test that values are bound
 	if viper.GetString("output.directory") != "/test/output" {
-- 
cgit v1.2.3