summaryrefslogtreecommitdiff
path: root/internal/io/fs/readfile_processor_optimized.go
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2025-07-02 17:01:13 +0300
committerPaul Buetow <paul@buetow.org>2025-07-02 17:01:13 +0300
commite74957dd14d0b1d996ae7b67f000f2bb6296c6a7 (patch)
treeed119163ad868c6a27c265b5a00020d7d5c65036 /internal/io/fs/readfile_processor_optimized.go
parente0cb2a417963b6515b16a5f12f36c7144d21f134 (diff)
perf: implement tiered buffer pooling to reduce allocations
- Add scanner_pool.go with tiered buffer pools (1MB, 64KB, 4KB) - Modify readWithProcessorOptimized to use pooled scanner buffers - Update tailWithProcessorOptimized to pool 64KB read buffers - Increase BytesBuffer pool initial capacity from 128B to 4KB - Add buffer_pool_test.go to benchmark pooling effectiveness This reduces memory allocations by ~36% in turbo mode by reusing buffers instead of allocating new ones for each file operation. All integration tests pass. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Diffstat (limited to 'internal/io/fs/readfile_processor_optimized.go')
-rw-r--r--internal/io/fs/readfile_processor_optimized.go17
1 files changed, 12 insertions, 5 deletions
diff --git a/internal/io/fs/readfile_processor_optimized.go b/internal/io/fs/readfile_processor_optimized.go
index bc7db05..716fb1f 100644
--- a/internal/io/fs/readfile_processor_optimized.go
+++ b/internal/io/fs/readfile_processor_optimized.go
@@ -33,12 +33,15 @@ func (f *readFile) readWithProcessorOptimized(ctx context.Context, fd *os.File,
// Use a scanner for efficient line reading
scanner := bufio.NewScanner(reader)
- // Set a custom buffer size for the scanner (default is 64KB, we'll use 1MB)
- // The second parameter is the maximum token size, not the buffer size
- buf := make([]byte, 1024*1024) // 1MB buffer
+ // Get a buffer from the pool instead of allocating a new one
+ bufPtr := pool.GetScannerBuffer()
+ buf := *bufPtr
maxTokenSize := 1024 * 1024 // 1MB max token size
scanner.Buffer(buf, maxTokenSize)
+ // Ensure we return the buffer to the pool when done
+ defer pool.PutScannerBuffer(bufPtr)
+
// Use custom split function that preserves line endings
scanner.Split(f.scanLinesPreserveEndings)
@@ -260,9 +263,13 @@ func (f *readFile) tailWithProcessorOptimized(ctx context.Context, fd *os.File,
partialLine := pool.BytesBuffer.Get().(*bytes.Buffer)
defer pool.RecycleBytesBuffer(partialLine)
+ // Get a buffer from the pool for reading
+ bufPtr := pool.GetMediumBuffer()
+ defer pool.PutMediumBuffer(bufPtr)
+
for {
- // Read available data
- buf := make([]byte, 64*1024) // 64KB buffer
+ // Read available data using pooled buffer
+ buf := (*bufPtr)[:cap(*bufPtr)] // Reset to full capacity
n, err := reader.Read(buf)
if n > 0 {