1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
|
package dlog
import (
"context"
"sync"
"testing"
"time"
"github.com/mimecast/dtail/internal/config"
"github.com/mimecast/dtail/internal/io/dlog/loggers"
)
// recordingLogger records whether a message arrived via the diagnostic (Log)
// path or the payload (Raw) path, so the test can assert how RawLog vs Raw route
// their messages. It reports SupportsColors()=false so the callers take their
// non-color branch (logger.Log / logger.Raw), which is what the routing test
// needs to observe.
type recordingLogger struct {
mutex sync.Mutex
logs []string
raws []string
}
func (r *recordingLogger) Log(now time.Time, message string) {
r.mutex.Lock()
defer r.mutex.Unlock()
r.logs = append(r.logs, message)
}
func (r *recordingLogger) LogWithColors(now time.Time, message, colored string) { r.Log(now, message) }
func (r *recordingLogger) Raw(now time.Time, message string) {
r.mutex.Lock()
defer r.mutex.Unlock()
r.raws = append(r.raws, message)
}
func (r *recordingLogger) RawWithColors(now time.Time, message, colored string) { r.Raw(now, message) }
func (r *recordingLogger) Start(ctx context.Context, wg *sync.WaitGroup) { wg.Done() }
func (r *recordingLogger) Flush() {}
func (r *recordingLogger) Pause() {}
func (r *recordingLogger) Resume() {}
func (r *recordingLogger) Rotate() {}
func (r *recordingLogger) SupportsColors() bool { return false }
var _ loggers.Logger = (*recordingLogger)(nil)
// TestRawLogUsesDiagnosticSink is the regression guard for the ReportServerError
// footgun: a server-error audit line must go through the diagnostic (Log) sink,
// not the payload (Raw) sink. Only the Log sink is written to the client log file
// by default (Client.LogPayload=false gates the Raw/payload sink out of the file),
// so a server error routed via Raw would silently vanish from the on-disk audit
// trail. This asserts RawLog -> Log and, for contrast, Raw -> Raw.
func TestRawLogUsesDiagnosticSink(t *testing.T) {
prevClient := config.Client
config.Client = &config.ClientConfig{TermColorsEnable: false}
t.Cleanup(func() { config.Client = prevClient })
rec := &recordingLogger{}
d := &DLog{logger: rec}
const serverError = "SERVER|srv1|ERROR|journal file targets require server capability journal-v1"
d.RawLog(serverError)
if len(rec.logs) != 1 || rec.logs[0] != serverError {
t.Fatalf("RawLog must reach the diagnostic (Log) sink verbatim; got logs=%v raws=%v",
rec.logs, rec.raws)
}
if len(rec.raws) != 0 {
t.Fatalf("RawLog must NOT use the payload (Raw) sink (it would be gated out of the file); got raws=%v",
rec.raws)
}
// Contrast: bulk payload still goes through the Raw/payload sink.
d.Raw("payload-line\n")
if len(rec.raws) != 1 || rec.raws[0] != "payload-line\n" {
t.Fatalf("Raw must reach the payload (Raw) sink; got raws=%v", rec.raws)
}
}
|
