1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
package fs
import (
"context"
"io"
"os"
"path/filepath"
"reflect"
"strings"
"testing"
"github.com/mimecast/dtail/internal/io/dlog"
"github.com/mimecast/dtail/internal/lcontext"
"github.com/mimecast/dtail/internal/regex"
)
func TestValidatedCatFileStartWithProcessorOptimizedReadsAllLines(t *testing.T) {
resetCommonLogger(t)
filePath := writeProcessorTestFile(t, "alpha\nbeta\n")
target := mustValidatedReadTarget(t, filePath)
re := regex.NewNoop()
cat := NewValidatedCatFile(filePath, target, "glob-id", make(chan string, 1), defaultMaxLineLength)
processor := &captureProcessor{}
if err := cat.readFile.StartWithProcessorOptimized(
context.Background(),
lcontext.LContext{},
processor,
re,
); err != nil {
t.Fatalf("validated optimized reader start failed: %v", err)
}
want := []string{"alpha\n", "beta\n"}
if !reflect.DeepEqual(processor.lines, want) {
t.Fatalf("unexpected processed lines: got=%v want=%v", processor.lines, want)
}
}
func TestValidatedReadTargetOpenRejectsEscapingSymlinkSwap(t *testing.T) {
resetCommonLogger(t)
baseDir := t.TempDir()
rootDir := filepath.Join(baseDir, "root")
outsideDir := filepath.Join(baseDir, "outside")
if err := os.MkdirAll(rootDir, 0755); err != nil {
t.Fatalf("mkdir root dir: %v", err)
}
if err := os.MkdirAll(outsideDir, 0755); err != nil {
t.Fatalf("mkdir outside dir: %v", err)
}
filePath := filepath.Join(rootDir, "app.log")
if err := os.WriteFile(filePath, []byte("alpha\n"), 0600); err != nil {
t.Fatalf("write app log: %v", err)
}
escapePath := filepath.Join(outsideDir, "secret.log")
if err := os.WriteFile(escapePath, []byte("secret\n"), 0600); err != nil {
t.Fatalf("write secret log: %v", err)
}
target := mustValidatedReadTarget(t, filePath)
if err := os.Remove(filePath); err != nil {
t.Fatalf("remove app log: %v", err)
}
relativeEscape, err := filepath.Rel(rootDir, escapePath)
if err != nil {
t.Fatalf("relative escape path: %v", err)
}
if err := os.Symlink(relativeEscape, filePath); err != nil {
t.Fatalf("symlink escape path: %v", err)
}
if _, err := target.Open(); err == nil {
t.Fatal("expected rooted open to reject escaping symlink swap")
}
}
func TestValidatedReadTargetOpenRejectsSameRootSymlinkSwap(t *testing.T) {
resetCommonLogger(t)
baseDir := t.TempDir()
filePath := filepath.Join(baseDir, "app.log")
if err := os.WriteFile(filePath, []byte("alpha\n"), 0600); err != nil {
t.Fatalf("write app log: %v", err)
}
otherPath := filepath.Join(baseDir, "other.log")
if err := os.WriteFile(otherPath, []byte("other\n"), 0600); err != nil {
t.Fatalf("write other log: %v", err)
}
target := mustValidatedReadTarget(t, filePath)
if err := os.Remove(filePath); err != nil {
t.Fatalf("remove app log: %v", err)
}
if err := os.Symlink(filepath.Base(otherPath), filePath); err != nil {
t.Fatalf("symlink other log: %v", err)
}
_, err := target.Open()
if err == nil {
t.Fatal("expected rooted open to reject same-root symlink swap")
}
if !strings.Contains(err.Error(), "symlink") {
t.Fatalf("expected symlink rejection, got %v", err)
}
}
func TestValidatedTailFileTruncatedReopenDetectsTruncation(t *testing.T) {
resetCommonLogger(t)
filePath := writeProcessorTestFile(t, "alpha\nbeta\n")
target := mustValidatedReadTarget(t, filePath)
tail := NewValidatedTailFile(filePath, target, "glob-id", make(chan string, 1), defaultMaxLineLength)
fd, err := target.Open()
if err != nil {
t.Fatalf("open validated target: %v", err)
}
defer fd.Close()
if _, err := fd.Seek(0, io.SeekEnd); err != nil {
t.Fatalf("seek end: %v", err)
}
if err := os.Truncate(filePath, 1); err != nil {
t.Fatalf("truncate file: %v", err)
}
isTruncated, err := tail.readFile.truncated(fd)
if !isTruncated {
t.Fatal("expected truncation to be detected")
}
if err == nil || !strings.Contains(err.Error(), "truncated") {
t.Fatalf("expected truncation error, got %v", err)
}
}
func mustValidatedReadTarget(t *testing.T, path string) ValidatedReadTarget {
t.Helper()
absolutePath, err := filepath.Abs(path)
if err != nil {
t.Fatalf("abs path: %v", err)
}
target, err := NewValidatedReadTarget(absolutePath)
if err != nil {
t.Fatalf("create validated target: %v", err)
}
return target
}
func resetCommonLogger(t *testing.T) {
t.Helper()
originalLogger := dlog.Common
dlog.Common = &dlog.DLog{}
t.Cleanup(func() {
dlog.Common = originalLogger
})
}
|
