1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
|
/* test_opener.c — %f expansion + launch with true/false.
*
* The argv-shape regression test (test_expand_weird_one_argv) calls
* _expand_command directly. That function is non-static in opener.c (with the
* `_` prefix retained to mark it as non-public) exactly so this test can
* inspect the parsed argv; it is declared here via an extern prototype rather
* than exposed in the public opener.h, to avoid public-header pollution. */
#include "opener.h"
#include <gio/gio.h>
#include <glib.h>
/* Non-static internal from opener.c (test-only accessor); see top-of-file
* comment. */
extern char **_expand_command(const char *c_cmd, GFile *p_file, GError **p_err);
static GFile *
make_tmp_file(void) {
GError *e = NULL;
char *d = g_dir_make_tmp("ggaze-opener-XXXXXX", &e);
g_assert_no_error(e);
char *p = g_build_filename(d, "test.txt", NULL);
GFile *f = g_file_new_for_path(p);
g_file_replace_contents(f, "x", 1, NULL, FALSE,
G_FILE_CREATE_REPLACE_DESTINATION, NULL, NULL, NULL);
g_free(p);
g_free(d);
return f;
}
/* Build a temp dir containing a file whose name has spaces, $, and backticks
* — the same "weird" pattern the original test_weird_filename used. */
static GFile *
make_weird_file(void) {
GError *e = NULL;
char *d = g_dir_make_tmp("ggaze-opener-XXXXXX", &e);
g_assert_no_error(e);
char *p = g_build_filename(d, "file with spaces $HOME `whoami`.jpg", NULL);
GFile *f = g_file_new_for_path(p);
g_file_replace_contents(f, "x", 1, NULL, FALSE,
G_FILE_CREATE_REPLACE_DESTINATION, NULL, NULL, NULL);
g_free(p);
g_free(d);
return f;
}
/* Delete p_file and its temp parent directory (recursing any leftover
* children so the dir removal succeeds). */
static void
cleanup_file(GFile *f) {
if (!f)
return;
GFile *d = g_file_get_parent(f);
g_file_delete(f, NULL, NULL);
if (d) {
GFileEnumerator *en = g_file_enumerate_children(
d, "standard::name", G_FILE_QUERY_INFO_NONE, NULL, NULL);
if (en) {
GFileInfo *i;
while ((i = g_file_enumerator_next_file(en, NULL, NULL))) {
GFile *c = g_file_get_child(d, g_file_info_get_name(i));
g_file_delete(c, NULL, NULL);
g_object_unref(c);
g_object_unref(i);
}
g_object_unref(en);
}
g_file_delete(d, NULL, NULL);
g_object_unref(d);
}
g_object_unref(f);
}
static void
test_launch_true(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"true", "true %f"};
GError *e = NULL;
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_launch_false(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"false", "false %f"};
GError *e = NULL;
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_weird_filename(void) {
GFile *f = make_weird_file();
Opener *o = opener_new();
OpenerProg prog = {"true", "true %f"};
GError *e = NULL;
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_quoted(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"sh -c 'true'", "sh -c 'true'"};
GError *e = NULL;
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_quoted_with_pctf(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"sh -c 'true %f'", "sh -c 'true %f'"};
GError *e = NULL;
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_escaped_spaces(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"escaped", "true a\\ b"};
GError *e = NULL;
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_option_flags(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"opts", "true -verbose %f"};
GError *e = NULL;
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_weird_filename_quoted(void) {
GFile *f = make_weird_file();
Opener *o = opener_new();
OpenerProg prog = {"sh -c 'true %f'", "sh -c 'true %f'"};
GError *e = NULL;
/* %f is substituted inside the already-parsed single argv element
* `true %f` → `true /weird/path`, passed as ONE arg to `sh -c`. */
g_assert_true(opener_launch(o, f, &prog, &e));
g_assert_no_error(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_malformed(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"bad", "sh -c 'echo hello"};
GError *e = NULL;
g_assert_false(opener_launch(o, f, &prog, &e));
g_assert_nonnull(e);
g_error_free(e);
opener_delete(o);
cleanup_file(f);
}
static void
test_empty(void) {
GFile *f = make_tmp_file();
Opener *o = opener_new();
OpenerProg prog = {"empty", ""};
GError *e = NULL;
g_assert_false(opener_launch(o, f, &prog, &e));
g_assert_nonnull(e);
g_error_free(e);
opener_delete(o);
cleanup_file(f);
}
/* The key regression test: with a weird filename (spaces + shell
* metacharacters) and an UNQUOTED %f template, the path must land in the
* parsed argv as exactly ONE element — not split on the path's spaces. `true`
* would ignore extra args, so a launch-only check cannot prove this; we
* inspect the argv shape directly via _expand_command. */
static void
test_expand_weird_one_argv(void) {
GFile *f = make_weird_file();
GError *e = NULL;
char **argv = _expand_command("true %f", f, &e);
g_assert_no_error(e);
g_assert_nonnull(argv);
/* argv = {"true", "<weird path>", NULL} — exactly three slots. */
g_assert_cmpstr(argv[0], ==, "true");
g_assert_nonnull(argv[1]);
g_assert_cmpstr(argv[2], ==, NULL);
/* The path element must equal the file's path verbatim, spaces and all. */
char *c_path = g_file_get_path(f);
g_assert_cmpstr(argv[1], ==, c_path);
g_free(c_path);
g_strfreev(argv);
cleanup_file(f);
}
/* A non-local GFile (no path) must be rejected with a GError rather than
* producing an argv with an embedded NULL that silently drops trailing args. */
static void
test_expand_no_local_path(void) {
GFile *f = g_file_new_for_uri("https://example.com/img.jpg");
GError *e = NULL;
char **argv = _expand_command("editor %f", f, &e);
g_assert_null(argv);
g_assert_nonnull(e);
g_error_free(e);
g_object_unref(f);
}
int
main(int argc, char **argv) {
g_test_init(&argc, &argv, NULL);
g_test_add_func("/opener/true", test_launch_true);
g_test_add_func("/opener/false", test_launch_false);
g_test_add_func("/opener/weird_filename", test_weird_filename);
g_test_add_func("/opener/quoted", test_quoted);
g_test_add_func("/opener/quoted_with_pctf", test_quoted_with_pctf);
g_test_add_func("/opener/escaped_spaces", test_escaped_spaces);
g_test_add_func("/opener/option_flags", test_option_flags);
g_test_add_func("/opener/weird_filename_quoted", test_weird_filename_quoted);
g_test_add_func("/opener/malformed", test_malformed);
g_test_add_func("/opener/empty", test_empty);
g_test_add_func("/opener/expand_weird_one_argv", test_expand_weird_one_argv);
g_test_add_func("/opener/expand_no_local_path", test_expand_no_local_path);
return g_test_run();
}
|
