summaryrefslogtreecommitdiff
path: root/internal/mcp
diff options
context:
space:
mode:
Diffstat (limited to 'internal/mcp')
-rw-r--r--internal/mcp/server.go13
-rw-r--r--internal/mcp/server_test.go9
2 files changed, 16 insertions, 6 deletions
diff --git a/internal/mcp/server.go b/internal/mcp/server.go
index 645c0cf..f8042ac 100644
--- a/internal/mcp/server.go
+++ b/internal/mcp/server.go
@@ -32,6 +32,7 @@ type Server struct {
syncer SlashCommandSyncer
initialized bool
mu sync.RWMutex
+ inflight sync.WaitGroup // tracks handler goroutines; Run waits before returning
// Dispatch table for JSON-RPC methods
handlers map[string]func(Request)
@@ -66,14 +67,16 @@ func NewServer(r io.Reader, w io.Writer, logger *log.Logger, store promptstore.P
}
// Run starts the server main loop, reading and dispatching requests.
-// Returns on EOF or fatal error.
+// Returns on EOF or fatal error, after waiting for all in-flight handlers.
func (s *Server) Run() error {
for {
body, err := s.readMessage()
if errors.Is(err, io.EOF) {
+ s.inflight.Wait() // drain handlers before signalling callers
return nil
}
if err != nil {
+ s.inflight.Wait()
return fmt.Errorf("read message: %w", err)
}
@@ -89,8 +92,12 @@ func (s *Server) Run() error {
continue
}
- // Dispatch request
- go s.handle(req)
+ // Dispatch request in a goroutine, tracked so Run can wait on completion.
+ s.inflight.Add(1)
+ go func(r Request) {
+ defer s.inflight.Done()
+ s.handle(r)
+ }(req)
}
}
diff --git a/internal/mcp/server_test.go b/internal/mcp/server_test.go
index 256b324..00a7823 100644
--- a/internal/mcp/server_test.go
+++ b/internal/mcp/server_test.go
@@ -430,14 +430,17 @@ func TestServer_Run(t *testing.T) {
t.Fatalf("sendRequest() error = %v", err)
}
- // Run in background
+ // Run in background; bytes.Buffer returns EOF after the single request,
+ // so Run() will complete naturally once it has written the response.
done := make(chan error, 1)
go func() {
done <- server.Run()
}()
- // Give time for processing (server will block waiting for more input)
- time.Sleep(50 * time.Millisecond)
+ // Wait for Run() to return (signalled by EOF on the input buffer).
+ if err := <-done; err != nil {
+ t.Fatalf("Run() error = %v", err)
+ }
// Read response
resp, err := readResponse(outBuf)