1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
|
package tracepoints
import (
"strings"
"testing"
)
func TestParseSelectorWithDimensionsDefaultFSOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected FS syscall openat to be attached by default")
}
if sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected non-FS syscall nanosleep to be excluded by default")
}
}
func TestParseSelectorWithDimensionsFamilyOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceFamilies: "Time",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected nanosleep to be attached when Time family is enabled")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only Time family is enabled")
}
}
func TestParseSelectorWithDimensionsKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "sleep",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected nanosleep to be attached for sleep kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only sleep kind is enabled")
}
}
func TestParseSelectorWithDimensionsPidfdKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "pidfd",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_pidfd_open") {
t.Fatal("expected pidfd_open to be attached for pidfd kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only pidfd kind is enabled")
}
}
func TestParseSelectorWithDimensionsFdKindIncludesProcessMadvise(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "fd",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_process_madvise") {
t.Fatal("expected process_madvise to be attached for fd kind")
}
if sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected nanosleep to be excluded when only fd kind is enabled")
}
}
func TestParseSelectorWithDimensionsEventfdKindIncludesEpollCreate(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "eventfd",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_epoll_create1") {
t.Fatal("expected epoll_create1 to be attached for eventfd kind")
}
if sel.ShouldAttach("sys_enter_epoll_wait") {
t.Fatal("expected epoll_wait to be excluded when only eventfd kind is enabled")
}
}
func TestParseSelectorWithDimensionsMemKindIncludesMlock(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "mem",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_mlock") {
t.Fatal("expected mlock to be attached for mem kind")
}
if !sel.ShouldAttach("sys_enter_mprotect") {
t.Fatal("expected mprotect to be attached for mem kind")
}
if sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected nanosleep to be excluded when only mem kind is enabled")
}
}
func TestParseSelectorWithDimensionsSeccompKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "seccomp",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_seccomp") {
t.Fatal("expected seccomp to be attached for seccomp kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only seccomp kind is enabled")
}
}
func TestParseSelectorWithDimensionsSysVOpKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "sysv-op",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_msgsnd") {
t.Fatal("expected msgsnd to be attached for sysv-op kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only sysv-op kind is enabled")
}
}
func TestParseSelectorWithDimensionsProcKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "proc",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_clone3") {
t.Fatal("expected clone3 to be attached for proc kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only proc kind is enabled")
}
}
func TestParseSelectorWithDimensionsBpfKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "bpf",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_bpf") {
t.Fatal("expected bpf to be attached for bpf kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only bpf kind is enabled")
}
}
func TestParseSelectorWithDimensionsFutexKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "futex",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_futex_waitv") {
t.Fatal("expected futex_waitv to be attached for futex kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only futex kind is enabled")
}
}
func TestParseSelectorWithDimensionsPrctlKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "prctl",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_prctl") {
t.Fatal("expected prctl to be attached for prctl kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only prctl kind is enabled")
}
}
func TestParseSelectorWithDimensionsTimerObjKindOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "timer-obj",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_timer_settime") {
t.Fatal("expected timer_settime to be attached for timer-obj kind")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded when only timer-obj kind is enabled")
}
}
func TestParseSelectorWithDimensionsSyscallOnly(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceSyscalls: "openat",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_openat") || !sel.ShouldAttach("sys_exit_openat") {
t.Fatal("expected both openat enter/exit tracepoints to be attached")
}
if sel.ShouldAttach("sys_enter_write") {
t.Fatal("expected write to be excluded when only openat is selected")
}
}
func TestParseSelectorWithDimensionsUnionSemantics(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceFamilies: "Time",
TraceSyscalls: "openat",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat from syscall selector")
}
if !sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected nanosleep from family selector")
}
}
func TestParseSelectorWithDimensionsExclusionsOverridePositives(t *testing.T) {
sel, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceFamilies: "FS",
NoTraceSyscalls: "openat",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded by -no-trace-syscalls")
}
if !sel.ShouldAttach("sys_enter_read") {
t.Fatal("expected other FS syscall (read) to remain attached")
}
}
func TestParseSelectorWithDimensionsRegexStillApplies(t *testing.T) {
sel, err := ParseSelectorWithDimensions("^sys_enter_openat$,^sys_exit_openat$", "", DimensionSelectorConfig{
TraceFamilies: "FS",
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to pass regex+dimension filters")
}
if sel.ShouldAttach("sys_enter_read") {
t.Fatal("expected read to fail regex attach filters")
}
}
func TestParseSelectorWithDimensionsRejectsInvalidFamily(t *testing.T) {
_, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceFamilies: "Nope",
})
if err == nil {
t.Fatal("expected error")
}
if !strings.Contains(err.Error(), "invalid syscall family") {
t.Fatalf("unexpected error: %v", err)
}
}
func TestParseSelectorWithDimensionsRejectsInvalidKind(t *testing.T) {
_, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceKinds: "not-a-kind",
})
if err == nil {
t.Fatal("expected error")
}
if !strings.Contains(err.Error(), "invalid syscall kind") {
t.Fatalf("unexpected error: %v", err)
}
}
func TestParseSelectorWithDimensionsRejectsInvalidSyscall(t *testing.T) {
_, err := ParseSelectorWithDimensions("", "", DimensionSelectorConfig{
TraceSyscalls: "not_a_syscall",
})
if err == nil {
t.Fatal("expected error")
}
if !strings.Contains(err.Error(), "invalid syscall in trace selector") {
t.Fatalf("unexpected error: %v", err)
}
}
func TestParseSelectorWithDimensionsRegexOnlyNanosleep(t *testing.T) {
// Regression: when -tps provides an explicit regex and no -trace-*
// dimension selectors are given, the implicit FS-only allowlist must not
// reject non-FS tracepoints such as nanosleep. Legacy regex-only
// semantics should let the regex control attachment.
sel, err := ParseSelectorWithDimensions(
"^sys_enter_nanosleep$,^sys_exit_nanosleep$", "",
DimensionSelectorConfig{},
)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected sys_enter_nanosleep to be attached by regex-only selector")
}
if !sel.ShouldAttach("sys_exit_nanosleep") {
t.Fatal("expected sys_exit_nanosleep to be attached by regex-only selector")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded by regex-only selector")
}
}
func TestParseSelectorWithDimensionsRegexPlusDimensionStillRestricts(t *testing.T) {
// When both a -tps regex and dimension selectors are provided, the
// dimension allowlist must still be enforced alongside the regex.
sel, err := ParseSelectorWithDimensions(
"^sys_enter_nanosleep$,^sys_exit_nanosleep$", "",
DimensionSelectorConfig{TraceFamilies: "Time"},
)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected nanosleep to pass both regex and Time family filter")
}
if sel.ShouldAttach("sys_enter_openat") {
t.Fatal("expected openat to be excluded by regex filter")
}
}
func TestParseSelectorWithDimensionsRegexOnlyExcludeStillWorks(t *testing.T) {
// When -tps is set with -tpsExclude but no dimension selectors, the
// exclude regex must still take effect.
sel, err := ParseSelectorWithDimensions(
"nanosleep", "sys_exit_nanosleep",
DimensionSelectorConfig{},
)
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if !sel.ShouldAttach("sys_enter_nanosleep") {
t.Fatal("expected sys_enter_nanosleep to be attached")
}
if sel.ShouldAttach("sys_exit_nanosleep") {
t.Fatal("expected sys_exit_nanosleep to be excluded by -tpsExclude regex")
}
}
func TestDimensionSelectorConfigHasAnySelector(t *testing.T) {
// Empty config has no selectors.
if (DimensionSelectorConfig{}).hasAnySelector() {
t.Fatal("expected empty config to report no selectors")
}
// Each individual field should count as a selector.
fields := []DimensionSelectorConfig{
{TraceFamilies: "FS"},
{TraceKinds: "sleep"},
{TraceSyscalls: "openat"},
{NoTraceFamilies: "FS"},
{NoTraceKinds: "sleep"},
{NoTraceSyscalls: "openat"},
}
for _, cfg := range fields {
if !cfg.hasAnySelector() {
t.Fatalf("expected config %+v to report selectors present", cfg)
}
}
}
|
