diff options
| author | Paul Buetow <paul@buetow.org> | 2026-02-18 10:10:39 +0200 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-02-18 10:10:39 +0200 |
| commit | 69f5017434298f1ffd4cdc30c30b95d0f4bd344f (patch) | |
| tree | c41a378bc8c4c7338f392cde7a4185658d4dfb12 /internal/display/display_test.go | |
| parent | f1951f2ee1e83d802030c257d4a1df099ec08976 (diff) | |
refactor: enforce Go best practices (function size, ordering, formatting)
- config: split set() (62L) into setSizeAndTuning() + setDisplayFlags()
- collector: split Run() (70L) into Run + startLocalScanner + startRemoteScanner
+ parseCollectorStream + dispatchCollectorLine; each <30L
- collector: remove unused script_embed.go (RemoteScript was dead code)
- display: move newRunState constructor before Run() per constructor-first rule
- display: replace loadPeak IIFE with a plain initLoadPeak variable
- display: split handleKey() (114L) into handleToggleKeys + handleAdjustAndSave
+ handleResizeKeys; add nil guard in handleResizeKeys for test safety
- display: split drawNetBarSmoothed() (75L) into drawNetBarSmoothed +
smoothNetUtilization + drawNetHalves; each <30L
- all: gofmt -w to fix formatting drift in display and config files
All tests pass (go test ./...).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to 'internal/display/display_test.go')
| -rw-r--r-- | internal/display/display_test.go | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/internal/display/display_test.go b/internal/display/display_test.go index 7d3e82e..16a7700 100644 --- a/internal/display/display_test.go +++ b/internal/display/display_test.go @@ -224,8 +224,8 @@ func TestMemBar_RamAndSwap(t *testing.T) { "cpu": {User: 100, System: 100, Idle: 800}, // needed so countBars > 0 }, Mem: map[string]int64{ - "MemTotal": 1000, - "MemFree": 400, // 60% used + "MemTotal": 1000, + "MemFree": 400, // 60% used "SwapTotal": 1000, "SwapFree": 600, // 40% used }, @@ -385,13 +385,13 @@ func TestMultiHost_BarCount(t *testing.T) { data: map[string]*stats.HostStats{ "alpha": { CPU: map[string]collector.CPULine{"cpu": alphaCur}, - Mem: map[string]int64{"MemTotal": 100, "MemFree": 50, "SwapTotal": 0, "SwapFree": 0}, - Net: map[string]stats.NetStamp{"eth0": {B: 0, Tb: 0, Stamp: 1.0}}, + Mem: map[string]int64{"MemTotal": 100, "MemFree": 50, "SwapTotal": 0, "SwapFree": 0}, + Net: map[string]stats.NetStamp{"eth0": {B: 0, Tb: 0, Stamp: 1.0}}, }, "beta": { CPU: map[string]collector.CPULine{"cpu": betaCur}, - Mem: map[string]int64{"MemTotal": 100, "MemFree": 50, "SwapTotal": 0, "SwapFree": 0}, - Net: map[string]stats.NetStamp{"eth0": {B: 0, Tb: 0, Stamp: 1.0}}, + Mem: map[string]int64{"MemTotal": 100, "MemFree": 50, "SwapTotal": 0, "SwapFree": 0}, + Net: map[string]stats.NetStamp{"eth0": {B: 0, Tb: 0, Stamp: 1.0}}, }, }, } @@ -631,7 +631,7 @@ func newHotkeyTestEnv(t *testing.T, cpuMode int, showMem, showNet bool) ( "SwapFree": 600, }, Net: map[string]stats.NetStamp{ - "eth0": {B: 12500000, Tb: 6250000, Stamp: 2.0}, + "eth0": {B: 12500000, Tb: 6250000, Stamp: 2.0}, "wlan0": {B: 1000000, Tb: 500000, Stamp: 2.0}, }, }, @@ -1216,7 +1216,7 @@ func TestGlobalIOAvgLine_MultiHost(t *testing.T) { defer surface.Free() prev1, cur1 := makeCPUPairWithIO(10, 10, 20, 20, 5, 5) // 30% IO - prev2, cur2 := makeCPUPair(40, 40, 20) // 0% IO + prev2, cur2 := makeCPUPair(40, 40, 20) // 0% IO cfg := defaultTestConfig() @@ -1554,9 +1554,9 @@ func TestMultiRow_DrawFrame(t *testing.T) { cfg.MaxBarsPerRow = 2 prev1, cur1 := makeCPUPair(100, 0, 0) // all system → blue - prev2, cur2 := makeCPUPair(0, 100, 0) // all user → yellow - prev3, cur3 := makeCPUPair(0, 0, 100) // all idle → black - prev4, cur4 := makeCPUPair(100, 0, 0) // all system → blue + prev2, cur2 := makeCPUPair(0, 100, 0) // all user → yellow + prev3, cur3 := makeCPUPair(0, 0, 100) // all idle → black + prev4, cur4 := makeCPUPair(100, 0, 0) // all system → blue src := &mockSource{ data: map[string]*stats.HostStats{ |
