diff options
| author | Paul Buetow <paul@buetow.org> | 2026-07-02 00:53:24 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-07-02 00:53:24 +0300 |
| commit | 58602a28d2c92b603208f3e01c14c169d28cc7b0 (patch) | |
| tree | 502d2e187ea29f2cc840e22d299d752d59088a3c /yhttpd/src/configure | |
| parent | 6c3a65b577f002f3219d03498c66205434765179 (diff) | |
yhttpd: port ychat fixes, get it building + stable in Docker (task 9s0)
Ports the ychat revival fixes (unsigned/size_t npos truncation, ofstream
== NULL, tool::trim OOB, CGI popen -> execve, www.yChat.org links, g++
version gate, config.pl -I., NCURSES/CLI-disabled build) so yhttpd builds
on modern GCC in a Rocky Linux 9 container, plus yhttpd-specific fixes
found while verifying it under concurrent load:
- listen() backlog was hardcoded to 1; bumped to SOMAXCONN.
- sock::_close() closed sockets with unread request bytes still in the
kernel receive buffer (read_http() only reads the GET line), so Linux
sent an abortive RST instead of a FIN, racing the client's read of the
response ("connection reset by peer" even though it was delivered).
Fixed with a non-blocking, bounded drain before close() - confirmed via
tcpdump: RSTs on every response before, zero after, across 140+
requests / concurrent bursts of 20.
- Removed a duplicate _make_server_socket() call in start() (wrap.cpp's
init_wrapper() already makes it before start() runs) that leaked a fd
and would have double-initialized SSL if OPENSSL is ever enabled;
caught by fresh-context review, documented honestly in DOCKER.md.
- src/configure's dependency-checker predates 64-bit multilib distros
(only checked /usr/lib, never /usr/lib64) and was missing an ncur
move-aside entry for the NCURSES-disabled build.
Added Dockerfile/.dockerignore/DOCKER.md documenting the build, the fixes,
and the one known-but-unfixed landmine (a SIGILL heap corruption in
sock::_close that reproduces on newer host GCC/glibc but not in the
container - latent, not fixed).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Diffstat (limited to 'yhttpd/src/configure')
| -rwxr-xr-x | yhttpd/src/configure | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/yhttpd/src/configure b/yhttpd/src/configure index 54cf650..b67da46 100755 --- a/yhttpd/src/configure +++ b/yhttpd/src/configure @@ -55,8 +55,11 @@ perl -e ' $ENV{HOME}."/lib", $ENV{HOME}."/usr/lib", "/lib", + "/lib64", "/usr/lib", + "/usr/lib64", "/usr/local/lib", + "/usr/local/lib64", "/usr/pkg/lib", "/opt/lib", "/opt/local/lib" @@ -65,6 +68,7 @@ perl -e ' my %dependfiles = ( database => ["data"], ycurses => ["curses", "ycui.cpp", "ycui.h"], + ncur => ["ncur"], logging => ["logd.cpp", "logd.h"], cli => ["cli"], opnssl => ["sock/sslsock.cpp", "sock/sslsock.h"] @@ -101,6 +105,16 @@ perl -e ' `mv ../backuped/$_ .` for @{$dependfiles{cli}}; } + if ( /\/\/#define NCURSES/ ) { + remove_from_array("ncurses.h",\@headers); + remove_from_array("libncurses.so",\@libs); + mkdir "../backuped" unless -d "../backuped"; + `mv $_ ../backuped` for @{$dependfiles{ncur}}; + } + elsif ( /^#define NCURSES/ && !-d "ncur") { + `mv ../backuped/$_ .` for @{$dependfiles{ncur}}; + } + if ( /\/\/#define YCURSES/ ) { for ("ncurses", "menu", "panel") { remove_from_array("$_.h",\@headers); |
